The UX is broken with v2.3.0 of @github/combobox-nav dependency #50
Comments
|
Would you kindly provide a reduced test case and we can look into it. |
earl-warren
pushed a commit
to earl-warren/gitea
that referenced
this issue
Dec 19, 2023
- The v2.3.0 update caused to always scroll to the suggestion menu, where it previously wouldn't work at all or only scroll when it wasn't in the viewport. - Ref: github/text-expander-element#50 - Ref: github/combobox-nav#75 - Resolves https://codeberg.org/forgejo/forgejo/issues/1990 (cherry picked from commit 27145be211ff782afe0910adbe200f126961f150)
|
Here is the sample for the bug: |
|
It should use "nearest" behavior IMO. |
|
If you want to raise a PR with the default to |
|
Use "nearest" behavior for scrollIntoView github/combobox-nav#79 Does it look good to you? Feel free to edit it directly or replace it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
A quick report that
v2.3.0 of @github/combobox-navand the new scrollIntoView broke the UX of @github/text-expander for me. It would push the expanded<ul>to the top of the screen. Also, when I scroll down with the keyboard over the available options (<li>elements), it would try to move the highlighted element to the top of the screen. After spending a few hours debugging what's the core of the issue, I noticed that the undesirable UX happens after the combobox-nav dependency of text-expander is upgraded to v2.3.0.I think this is the PR that's bugging the behaviour github/combobox-nav#75
If someone else is facing this issue, my solution was to fix combobox-nav to v2.2.0 through "resolutions" section of package.json.
The text was updated successfully, but these errors were encountered: