Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slide "Help" JS Errros #59

Closed
jordanmccullough opened this issue Mar 18, 2014 · 2 comments
Closed

Slide "Help" JS Errros #59

jordanmccullough opened this issue Mar 18, 2014 · 2 comments
Assignees
@jordanmccullough

Comments

@jordanmccullough
Copy link

The auto-showing Help panel for slide decks is experiencing JS issues.

screen shot 2014-03-18 at 10 16 51 am
@jordanmccullough jordanmccullough self-assigned this Mar 18, 2014
@jordanmccullough
Copy link
Author

Investigating why this has recently arisen in Chrome 33.0.1750.152

@jordanmccullough
Copy link
Author

Help plugin argument error. Seems Safari just lets this slip by, whereas Chrome enforces both arguments.
Was:
helpTarget.setAttribute("class");

Needs:
helpTarget.setAttribute("class", "");

jordanmccullough pushed a commit that referenced this issue Mar 18, 2014
Merge pull request #60 from github/slide-help-fix
906cde2 
Update HydeSlides Plugins, closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanmccullough jordanmccullough

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordanmccullough