Curriculum layout and js tune up #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good. I wouldn't say that hyphenation is a big deal. |
|
Hyphenation support now in here, so tada! |
|
I kinda reviewed the JS. Not easy to grok, but that's not a complaint. Basically, just trusting you on this one having test-driven it locally. |
added 5 commits
August 12, 2014 19:25
…nd-js-tune-up Conflicts: _stylesheets/page.css
Previously broke JS parsing for heading and TOC build-out
jordanmccullough
changed the title
|
|
|
Tested it locally. So much nicer. Shipping it, then updating my foundations Markdown file to strip out the numbers on the sections. |
matthewmccullough
pushed a commit
that referenced
this pull request
Aug 13, 2014
Curriculum layout and js tune up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #172