Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Persian translation #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Persian translation #673

wants to merge 1 commit into from

Conversation

Goudarz
Copy link

@Goudarz Goudarz commented Apr 1, 2019

No description provided.

@brianamarie
Copy link
Contributor

Hello @Goudarz! Thank you for your contributions! Before merging, we typically like to get pull requests reviewed by someone other than the author. Since nobody on this team speaks Persian, we can't review it. Do you know any other Persian speakers on GitHub who could review this pull request? Thanks! ✨

@jaco693
Copy link

jaco693 commented May 23, 2019

See if I can fix it

@Cloud-Mak
Copy link

Hi,
I am learning about the PR and github in genral. Just curious as to why this PR is still open. May be @brianamarie can comment. Please excuse if this isn't correct way of seeking help.

@brianamarie
Copy link
Contributor

I am learning about the PR and github in genral. Just curious as to why this PR is still open. May be @brianamarie can comment. Please excuse if this isn't correct way of seeking help.

Hi @Cloud-Mak! Welcome to GitHub! If you haven't already, I recommend going through the First Day on GitHub Learning Path on Learning Lab. That is a great place to start for new users.

This PR is still open because it hasn't gotten the necessary reviews to be merged. Because this pull request makes changes that are not in English, the team that maintains this repository needs help. Once this pull request gets approved by another user who speaks the target language in this pull request, then we will be able to take a closer look and merge. Does that answer your question?

Copy link

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianamarie
Copy link
Contributor

Thank you for the review, @mahdyar!

Unfortunately I am not able to resolve the conflicts as a non-Persian speaker. @Goudarz, could you please resolve the conflicts as you see fit? Or, is there someone else who could offer suggestions on how to resolve the conflicts?

@asma-khordsal
Copy link

سلام Goudarz ! ممنون از مشارکت های شما! قبل از ادغام ، معمولاً می خواهیم درخواست های کشش را دریافت کنیم که توسط شخص دیگری غیر از نویسنده بررسی می شود. از آنجا که هیچ کس در این تیم به فارسی صحبت نمی کند ، نمی توانیم آن را مرور کنیم. آیا فارسی زبان دیگری در GitHub سراغ دارید که بتواند این درخواست کشش را بررسی کند؟ با تشکر!✨

بنده فارسی زبان هستم فقط نمیدانم اینجا چی هست و باید چه کاری انجام دهم

سلام Goudarz ! ممنون از مشارکت های شما! قبل از ادغام ، معمولاً می خواهیم درخواست های کشش را دریافت کنیم که توسط شخص دیگری غیر از نویسنده بررسی می شود. از آنجا که هیچ کس در این تیم به فارسی صحبت نمی کند ، نمی توانیم آن را مرور کنیم. آیا فارسی زبان دیگری در GitHub سراغ دارید که بتواند این درخواست کشش را بررسی کند؟ با تشکر!✨

بنده فارسی زبان هستم فقط نمیدانم اینجا چه کاری باید انجام بدم

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants