-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo t -> T #1
Comments
Sorry, I don't understand the purpose of your comment. |
apologies, just came across your repo via your CN thread It may be case insensitive ( I do see the use of "post" elsewhere) Just advocating for consistency, Great job by the way. well done. |
Thank you for pointing that out. That is in experimental code and probably has never been called. I would have wondered why it did not work or perhaps did but got distracted. That feature (measure transparency) is experimental and I have decided it can not be relied upon. At the time I wrote it I was not so experienced with github and now would have created a development branch for it.
Dale
… On 01/07/2023 3:54 PM Tom Conlin ***@***.***> wrote:
apologies, just came across your repo via your CN thread
scanning the code looking for what solver you were using,
my eye got snagged on the inconsistent letter case in the word "POSt"
on the given line.
It may be case insensitive ( I do see the use of "post" elsewhere)
Just advocating for consistency,
if it were me, I would have done it by mistake and want to fix it.
Great job by the way. well done.
—
Reply to this email directly, view it on GitHub #1 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2BJLBV3BHDBEHOHWLZTQDWRHQYBANCNFSM6AAAAAATUEE6EE .
You are receiving this because you commented.Message ID: ***@***.***>
|
https://github.com/githubdoe/skysolve/blob/main/skysolve.py#L808
The text was updated successfully, but these errors were encountered: