Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move lint into separate workflow #1246

Merged
merged 5 commits into from
Jun 16, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 15, 2024

No description provided.

@setchy setchy added the build Build, action or package manager changes label Jun 15, 2024
@setchy setchy added this to the Release 5.9.0 milestone Jun 15, 2024
@setchy setchy changed the title build: split linting out build: move lint into separate workflow Jun 15, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, why exactly?

@setchy
Copy link
Member Author

setchy commented Jun 16, 2024

Hmmm, why exactly?

Explicit check feedback

@afonsojramos
Copy link
Member

Hmmm, why exactly?

Explicit check feedback

Isn't looking at the workflow failure reason not enough? 😅

@setchy
Copy link
Member Author

setchy commented Jun 16, 2024

Hmmm, why exactly?

Explicit check feedback

Isn't looking at the workflow failure reason not enough? 😅

I think it's more intuitive if it is a separate step, whether that's a separate workflow file (lint.yml) or the same (test.yml).

We have this clarity already in Build App and Release App and Validators 😎

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not :D

@afonsojramos afonsojramos merged commit c3cce3d into main Jun 16, 2024
10 checks passed
@afonsojramos afonsojramos deleted the build/split-linting-out branch June 16, 2024 10:20
@bmulholland
Copy link
Collaborator

IMHO this is best practice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, action or package manager changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants