Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use macos-latest runners #1247

Merged
merged 1 commit into from
Jun 16, 2024
Merged

build: use macos-latest runners #1247

merged 1 commit into from
Jun 16, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 15, 2024

Update to use macos-latest tag now that it's equal to macos-14 now

Also update our tests workflow to run on macos instead of ubuntu, since the maintainer group are all macos users.

@setchy setchy added the build Build, action or package manager changes label Jun 15, 2024
@setchy setchy added this to the Release 5.9.0 milestone Jun 15, 2024
@setchy setchy changed the title build: use macos-latest build: use macos-latest runners Jun 15, 2024
@@ -9,7 +9,7 @@ on:
jobs:
run-unit-tests:
name: Run Tests
runs-on: ubuntu-latest
runs-on: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're lucky we're open source, because the MacOS multiplier for actions minutes is crazy 😬

Outside of this, I think it is good practice to only not use Linux if really required.

@setchy setchy merged commit befbc38 into main Jun 16, 2024
13 checks passed
@setchy setchy deleted the build/macos branch June 16, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, action or package manager changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants