Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch notifications on navigation #1305

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat: fetch notifications on navigation #1305

merged 4 commits into from
Jun 25, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 21, 2024 •
edited
Loading

Currently fetchNotifcations is called each time when a subset of settings are changed.

This can cause rate limiting if enough settings are changed in quick succession.

Instead, this PR moves the retrieve new notifications to occur when moving back to the Notifications screen, either by;

  • clicking the Go Back button in the header
  • clicking on the Sidebar Settings icon

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 21, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 21, 2024
@setchy setchy mentioned this pull request Jun 21, 2024
Merged
@setchy setchy changed the title feat: fetch notifications on back feat: fetch notifications on back navigation Jun 21, 2024
@setchy setchy changed the title feat: fetch notifications on back navigation feat: fetch notifications on navigation Jun 22, 2024
afonsojramos
afonsojramos approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A definite improvement!

@afonsojramos afonsojramos merged commit e700b8b into main Jun 25, 2024
7 checks passed
@afonsojramos afonsojramos deleted the feat/fetch-on-back branch June 25, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@setchy @afonsojramos