Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade to Jest 29 #617

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

bmulholland
Copy link
Collaborator

No description provided.

@bmulholland
Copy link
Collaborator Author

@bmulholland
Copy link
Collaborator Author

bmulholland commented Sep 28, 2023

@afonsojramos Upgrading these packages required several chained upgrades. I used Graphite, a tool which makes it easy to stack changes like this, to break them up instead of having one massive PR. Graphite can also handle merging all of them without having to manually rebase -- just review + approve, and I can hit one button to make that all happen. (Or, you can set up an account with Graphite, and do that yourself via their UI.)

The only thing left before I'm comfortable merging it all is manually testing the React upgrade. See my comment there.

package.json Outdated Show resolved Hide resolved
Base automatically changed from 09-27-Upgrade_to_Jest_28 to main September 28, 2023 10:08
@afonsojramos
Copy link
Member

without having to manually rebase -- just review + approve

lol, read this after manually rebasing/merging everything :)

@afonsojramos
Copy link
Member

@bmulholland is the button a premium feature? can't see it anywhere :( But Graphite looks really cool, thanks for the tip!

@bmulholland
Copy link
Collaborator Author

No, it's free. Top right of https://app.graphite.dev/github/pr/gitify-app/gitify/617/chore-deps-Upgrade-to-Jest-29

You have to use it before the conflict happens though :\

@bmulholland
Copy link
Collaborator Author

bmulholland commented Oct 2, 2023

@afonsojramos Should be good to go now :). Need your review to merge.

@afonsojramos afonsojramos merged commit 286c415 into main Oct 2, 2023
8 checks passed
@afonsojramos afonsojramos deleted the 09-27-Upgrade_to_Jest_29 branch October 2, 2023 08:07
@setchy setchy added the dependency Dependency updates label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants