refactor: simplify notification html url logic #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setchy
changed the title
bmulholland
reviewed
Feb 19, 2024
bmulholland
reviewed
Feb 20, 2024
|
This PR is now ready for review @afonsojramos @bmulholland. In addition to simplifying the html_url logic (no more string manipulation), this now has increased unit test coverage, and in doing so resolved an edge-base bug for Discussions url generation. |
bmulholland
approved these changes
Feb 22, 2024
|
Yep, LGTM! |
adufr
pushed a commit
to adufr/gitify
that referenced
this pull request
Mar 25, 2024
* refactor: simplify html url * fix: add test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch the most appropriate html url for the notification based off the notification API response.
Order is
Removes or simplifies a lot of string manipulation to generate the link, add in comment anchors and referrer ids.
Note: tests still need to be reworked given the logic changes in helper.ts