Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ci workflow notifications #766

Closed
wants to merge 16 commits into from

Conversation

setchy
Copy link
Member

@setchy setchy commented Feb 15, 2024

Closes #381 and #526

@setchy setchy marked this pull request as draft February 15, 2024 14:14
@setchy setchy marked this pull request as ready for review February 15, 2024 17:58
@setchy
Copy link
Member Author

setchy commented Feb 15, 2024

Notification title parsing was required since the Notification Event payload doesn't contain any status, branch or workflow name details. Similarly, I couldn't find an API to query for these given a notification id

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Feb 16, 2024
@setchy setchy marked this pull request as draft February 18, 2024 18:32
@setchy
Copy link
Member Author

setchy commented Feb 22, 2024

#793 to be merged prior to this enhancement

@setchy
Copy link
Member Author

setchy commented Feb 22, 2024

Found an API that looks promising. Will explore that route rather than string regexing

@setchy
Copy link
Member Author

setchy commented Feb 22, 2024

Although the Check Suite API would be a perfect fit our needs, there is no joining identifier (that i can see) within the List Notifications response to be able to make it useful.

What we would have to do call List Workflow Runs for a Repository and parse the results, in order to get conclusion value etc.

With this in mind, I suggest for now we continue down the path of inferring the key values based on the workflow title

@setchy
Copy link
Member Author

setchy commented Feb 24, 2024

Split this into #819, #820 and #821

@setchy setchy closed this Feb 24, 2024
@setchy setchy deleted the feature/action-workflow-link branch March 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Click through to PR when GitHub Actions run completes
1 participant