-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1165 - Adds options to modify file annotation button behaviour #1171
Conversation
81422dc
to
589e2fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Unfortunately we can't use the gitlens.menus
setting as you have here, since it will break how that setting is used elsewhere (since its set as an object). So we'll need to come up with another setting name -- maybe add a new fileAnnotations.command
setting, that defaults to null
(which would mean show the menu), or be an enum of blame
, changes
, heatmap
. We probably will also need to add a fileAnnotations.diffCommand
setting, which is the same as fileAnnotations.command
, but can't be set to changes
.
I've combined and replaced the settings with |
@arrpee Thanks! Looking great! I currently have the Changes file annotations disabled when you are in a diff editor -- but thinking about that more I don't think that is needed anymore. So I think we can just move ahead without anything like |
README.md
Outdated
| Name | Description | | ||
| -------------------------------------- | -------------------------------------------------------------------------------------------------------------------- | | ||
| `gitlens.menus` | Specifies which commands will be added to which menus | | ||
| `gitlens.menus.annotations.behaviour` | Specifies whether the file annotations button in the editor title acts as a menu (default) or a toggle button | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remove this and document the new gitlens.fileAnnotations.command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the changes
Description
Adds two options to modify the behaviour of the file annotations button:
I wasn't too sure of what to name the settings so if you can suggest more appropriate ones that would be great.
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses