Smartly guess the protocol and port for the remote provider #1984
+221
−112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the remote provider uses https by default and allow users to set a different protocol if they want in the configuration.
This is kept, but now, we try to infer the best protocol by looking at the git remote URL.
And, previously, no custom ports were allowed to be set. This is still true, but now, we try to infer the best port by looking at the git remote URL.
Fixes #632
Fixes #1918
Refs #1964
Maybe more.
TODOs
remoteProvider.protocol
fromhttps
toauto
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses