Change always passing visible true tests to false.

gitlabhq · Sep 29, 2014 · 12cdbef · 12cdbef
1 parent efcac2b
commit 12cdbef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/features/steps/shared/diff_note.rb b/features/steps/shared/diff_note.rb
@@ -73,13 +73,13 @@ module SharedDiffNote
 
   step 'I should not see the diff comment preview button' do
     within(diff_file_selector) do
-      page.should have_css(".js-note-preview-button", visible: false)
+      page.should_not have_css('.js-note-preview-button', visible: true)
     end
   end
 
   step 'I should not see the diff comment text field' do
     within(diff_file_selector) do
-      page.should have_css(".js-note-text", visible: false)
+      page.should_not have_css('.js-note-text', visible: true)
     end
   end
 
@@ -114,7 +114,7 @@ module SharedDiffNote
   end
 
   step 'I should see add a diff comment button' do
-    page.should have_css(".js-add-diff-note-button", visible: false)
+    page.should have_css('.js-add-diff-note-button', visible: true)
   end
 
   step 'I should see an empty diff comment form' do
@@ -131,7 +131,7 @@ module SharedDiffNote
 
   step 'I should see the diff comment preview' do
     within("#{diff_file_selector} form") do
-      page.should have_css(".js-note-preview", visible: false)
+      page.should have_css('.js-note-preview', visible: true)
     end
   end
 

diff --git a/features/steps/shared/note.rb b/features/steps/shared/note.rb
@@ -51,19 +51,19 @@ module SharedNote
 
   step 'I should not see the comment preview' do
     within(".js-main-target-form") do
-      page.should have_css(".js-note-preview", visible: false)
+      page.should_not have_css('.js-note-preview', visible: true)
     end
   end
 
   step 'I should not see the comment preview button' do
     within(".js-main-target-form") do
-      page.should have_css(".js-note-preview-button", visible: false)
+      page.should_not have_css('.js-note-preview-button', visible: true)
     end
   end
 
   step 'I should not see the comment text field' do
     within(".js-main-target-form") do
-      page.should have_css(".js-note-text", visible: false)
+      page.should_not have_css('.js-note-text', visible: true)
     end
   end