Skip to content

Commit

Permalink
Factor issue and edit MR form label field and submit.
Browse files Browse the repository at this point in the history
  • Loading branch information
cirosantilli committed Sep 22, 2014
1 parent 248990b commit 705fe01
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 34 deletions.
5 changes: 5 additions & 0 deletions app/models/issue.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,9 @@ def gfm_reference
def reset_events_cache
Event.reset_event_cache_for(self)
end

# To allow polymorphism with MergeRequest.
def source_project
project
end
end
17 changes: 17 additions & 0 deletions app/views/projects/_issuable_form.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,20 @@
Milestone
.col-sm-10= f.select(:milestone_id, milestone_options(issuable),
{ include_blank: 'Select milestone' }, { class: 'select2' })
.form-group
= f.label :label_ids, class: 'control-label' do
%i.icon-tag
Labels
.col-sm-10
= f.collection_select :label_ids, issuable.project.labels.all, :id, :name,
{ selected: issuable.label_ids }, multiple: true, class: 'select2'
.form-actions
- if issuable.new_record?
= f.submit "Submit new #{issuable.class.model_name.human.downcase}", class: 'btn btn-create'
- else
= f.submit 'Save changes', class: 'btn btn-save'
- if issuable.new_record?
- cancel_project = issuable.source_project
- else
- cancel_project = issuable.project
= link_to 'Cancel', [cancel_project, issuable], class: 'btn btn-cancel'
15 changes: 0 additions & 15 deletions app/views/projects/issues/_form.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,6 @@

= form_for [@project, @issue], html: { class: 'form-horizontal issue-form' } do |f|
= render 'projects/issuable_form', f: f, issuable: @issue
.form-group
= f.label :label_ids, class: 'control-label' do
%i.icon-tag
Labels
.col-sm-10
= f.collection_select :label_ids, @project.labels.all, :id, :name, { selected: @issue.label_ids }, multiple: true, class: 'select2'

.form-actions
- if @issue.new_record?
= f.submit 'Submit new issue', class: "btn btn-create"
-else
= f.submit 'Save changes', class: "btn-save btn"

- cancel_path = @issue.new_record? ? project_issues_path(@project) : project_issue_path(@project, @issue)
= link_to "Cancel", cancel_path, class: 'btn btn-cancel'

:javascript
$('.assign-to-me-link').on('click', function(e){
Expand Down
19 changes: 0 additions & 19 deletions app/views/projects/merge_requests/_form.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,8 @@
Please review the
%strong #{link_to "guidelines for contribution", contribution_guide_url}
to this repository.

.merge-request-form-info
= render 'projects/issuable_form', f: f, issuable: @merge_request
.form-group
= f.label :label_ids, class: 'control-label' do
%i.icon-tag
Labels
.col-sm-10
= f.collection_select :label_ids, @merge_request.target_project.labels.all, :id, :name, { selected: @merge_request.label_ids }, multiple: true, class: 'select2'

.form-actions
- if @merge_request.new_record?
= f.submit 'Submit merge request', class: "btn btn-create"
-else
= f.submit 'Save changes', class: "btn btn-save"
- if @merge_request.new_record?
= link_to project_merge_requests_path(@source_project), class: "btn btn-cancel" do
Cancel
- else
= link_to project_merge_request_path(@target_project, @merge_request), class: "btn btn-cancel" do
Cancel

:javascript
disableButtonIfEmptyField("#merge_request_title", ".btn-save");
Expand Down

0 comments on commit 705fe01

Please sign in to comment.