-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix confusing situation where install guide told you to install init.…
…d script for puma.
- Loading branch information
Showing
7 changed files
with
10 additions
and
248 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
7c55c73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some additional things in EE need to be changed to move back to Unicorn.
I redirected the init script to show this error:
/usr/local/lib/ruby/gems/2.0.0/gems/bundler-1.3.5/lib/bundler/rubygems_integration.rb:214:in
'block in replace_gem': unicorn is not part of the bundle. Add it to Gemfile. (Gem::LoadError) from /home/git/gitlab/vendor/bundle/ruby/2.0.0/bin/unicorn_rails:22:in
bundle install in the gitlab dir does not install unicorn.
7c55c73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it.
Why you brought back unicorn by default when puma is faster and better, and the most important thing: it worked when unicorn is not (in this configuration) ?
Had to do
git checkout 6ec73fc9a64938566d2e6d1a804990fa0f8849f0z
to get back puma.7c55c73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @dosire said: "Puma caused 100% CPU and greater memory leaks when running mult-ithreaded on systems with many concurrent users."