Skip to content

Commit

Permalink
Revert "Increase timeout for Git-over-HTTP requests."
Browse files Browse the repository at this point in the history
This reverts commit 516bcab.

Conflicts:
	Gemfile
  • Loading branch information
dzaporozhets committed Mar 20, 2015
1 parent 915c7b9 commit efd8491
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 49 deletions.
3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,6 @@ gem 'mousetrap-rails'
# Detect and convert string character encoding
gem 'charlock_holmes'

# Shutting down requests that take too long
gem "slowpoke"

gem "sass-rails", '~> 4.0.2'
gem "coffee-rails"
gem "uglifier"
Expand Down
8 changes: 0 additions & 8 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ GEM
enumerize (0.7.0)
activesupport (>= 3.2)
equalizer (0.0.8)
errbase (0.0.2)
erubis (2.7.0)
escape_utils (0.2.4)
eventmachine (1.0.4)
Expand Down Expand Up @@ -429,7 +428,6 @@ GEM
rack
rack-test (0.6.3)
rack (>= 1.0)
rack-timeout (0.2.0)
rails (4.1.9)
actionmailer (= 4.1.9)
actionpack (= 4.1.9)
Expand Down Expand Up @@ -482,8 +480,6 @@ GEM
rest-client (1.6.7)
mime-types (>= 1.16)
rinku (1.7.3)
robustly (0.0.3)
errbase
rouge (1.7.4)
rspec (2.99.0)
rspec-core (~> 2.99.0)
Expand Down Expand Up @@ -566,9 +562,6 @@ GEM
temple (~> 0.6.6)
tilt (>= 1.3.3, < 2.1)
slop (3.6.0)
slowpoke (0.0.5)
rack-timeout (>= 0.1.0)
robustly
spinach (0.8.7)
colorize (= 0.5.8)
gherkin-ruby (>= 0.3.1)
Expand Down Expand Up @@ -778,7 +771,6 @@ DEPENDENCIES
six
slack-notifier (~> 1.0.0)
slim
slowpoke
spinach-rails
spring (~> 1.3.1)
spring-commands-rspec (= 1.0.4)
Expand Down
8 changes: 0 additions & 8 deletions config/initializers/timeout.rb

This file was deleted.

20 changes: 16 additions & 4 deletions config/unicorn.rb.example
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,22 @@ working_directory "/home/git/gitlab" # available in 0.94.0+
listen "/home/git/gitlab/tmp/sockets/gitlab.socket", :backlog => 1024
listen "127.0.0.1:8080", :tcp_nopush => true

# Kill workers after 1 hour.
# A shorter timeout of 60 seconds is enforced by rack-timeout for web requests.
# Git-over-HTTP only has the below timeout since large pulls/pushes can take a long time.
timeout 60 * 60
# nuke workers after 30 seconds instead of 60 seconds (the default)
#
# NOTICE: git push over http depends on this value.
# If you want be able to push huge amount of data to git repository over http
# you will have to increase this value too.
#
# Example of output if you try to push 1GB repo to GitLab over http.
# -> git push http://gitlab.... master
#
# error: RPC failed; result=18, HTTP code = 200
# fatal: The remote end hung up unexpectedly
# fatal: The remote end hung up unexpectedly
#
# For more information see http://stackoverflow.com/a/21682112/752049
#
timeout 60

# feel free to point this anywhere accessible on the filesystem
pid "/home/git/gitlab/tmp/pids/unicorn.pid"
Expand Down
13 changes: 0 additions & 13 deletions lib/gitlab/middleware/timeout.rb

This file was deleted.

13 changes: 0 additions & 13 deletions public/503.html

This file was deleted.

0 comments on commit efd8491

Please sign in to comment.