Issues bulk update #3956
Merged
Issues bulk update #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@randx, cleanup based on my suggestion on your commit |
|
Coverage increased (+0%) when pulling 32487561f5bb26602fe8d3e0595ab55cd9c94854 on AlexDenisov:issues_bulk_update into f7f6ace on gitlabhq:master. |
| @@ -8,6 +8,13 @@ def execute | |||
| assignee_id = update_data[:assignee_id] | |||
| status = update_data[:status] | |||
|
|
|||
| unless status.present? | |||
There was a problem hiding this comment.
what if I want just to update assignee or milestone? status will be blank in this case
There was a problem hiding this comment.
Sorry, that's my fault.
I'll revert this cleanup and add few more tests for those cases.
|
@randx, I've rewrote "cleanup" and added few more tests. |
|
Seems that fail is unrelated |
|
@AlexDenisov thank you |
|
You're welcome ;-) |
dzaporozhets
pushed a commit
that referenced
this pull request
Jan 14, 2016
Improve the consistency of commit titles, branch names, tag names, issue/MR titles, on their respective project pages See #3956. Following is before/after for each page: ## Group title ### Before  ### After  --- ## Commit title ### Before  ### After  --- ## Branch name ### Before  ### After  --- ## Tags name in list ### Before  ### After  --- ## Tag name ### Before  ### After  --- ## Issue title in list ### Before  ### After  --- ## MR title in list ### Before  ### After  See merge request !2422
rspeicher
pushed a commit
that referenced
this pull request
Jan 15, 2016
Fix alignment issues after a fix on titles weight Fixes #8102. Fixes #3956. This fixes an alignment regression introduced by !2422. Sorry about that! :/ ## Commit title alignment fixed  **The fact that the first row has a smaller height than the other rows was not introduced by !2422 (I've checked by reverting 818607f on `master`).** ## Tags name in list  See merge request !2431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added few specs and cleanup a bit.