Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: keep the Rails secret token out of version control. #4040

Merged
merged 1 commit into from May 23, 2013

Conversation

smashwilson
Copy link
Contributor

This patch stores the secret token in a .gitignored file called ".secret", which is
created by the initializer if it doesn't exist. This keeps the Rails session token out of version control and deals with a security vulnerability.

For reference:

http://blog.phusion.nl/2013/01/04/securing-the-rails-session-secret/

http://blog.codeclimate.com/blog/2013/03/27/rails-insecure-defaults/ (Item 3)

Store the secret token in a .gitignored file called ".secret", which is
created by the initializer if it doesn't exist.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling e444c7f on smashwilson:generate-secret into c5de01f on gitlabhq:master.

@senny
Copy link
Contributor

senny commented May 23, 2013

@randx @dosire please take a look.

@dzaporozhets
Copy link
Member

+1

dzaporozhets added a commit that referenced this pull request May 23, 2013
Security: keep the Rails secret token out of version control.
@dzaporozhets dzaporozhets merged commit c33a590 into gitlabhq:master May 23, 2013
@smashwilson smashwilson deleted the generate-secret branch May 28, 2013 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants