Automatically generate debian package with pkgr.io #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Request to first merge commits 6cd937d (Allow to parse heroku-generated database.yml config file), and 6a80933 (Fix Procfile to be usable in production). |
| @@ -1,2 +1,2 @@ | |||
| web: bundle exec unicorn_rails -p $PORT -E development -c config/unicorn_development.rb | |||
| web: bundle exec unicorn_rails -p ${PORT} -E ${RAILS_ENV} -c ${UNICORN_CONFIG:="config/unicorn.rb"} | |||
There was a problem hiding this comment.
Why are this changes needed?
|
@dosire What about creating two seperate MR's for those fixes? That might clearify things a little |
|
@jvanbaarsen I suggested creating separate MR's to @crohr but this was not done. I asked again. |
|
@dosire Ok thanks :) |
This was referenced Apr 7, 2014
|
@crohr Thanks for the split MR's! |
This was referenced Apr 15, 2014
|
Rebased against latest master, and added support for Ubuntu 14.04 to the mix. Also, packages are now automatically tested for regressions (see https://github.com/pkgr/showcase repository if you're curious). Anything I can do to help the review on #6726 ? |
… environment variable. This only applies to packaging with https://pkgr.io.
dosire
added a commit
that referenced
this pull request
May 6, 2014
Automatically generate debian package with pkgr.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes I had to make to generate debian packages of Gitlab for Ubuntu 12.04 and Debian 7.4, using https://pkgr.io. The installation process is currently described in https://pkgr.io/apps/pkgr/gitlabhq.
In addition to the specific stuff related to packaging, I added a new
gitlab:shell:installto streamline the installation of gitlab-shell (with auto-generation of its config.yml file), and a way to set the Gitlab configuration using environment variables. Please let me know what you think.