Only search gitlab:import:repos on repos on subdir [failure unrelated][can be updated] #8140
Conversation
|
I've prepared a stage. Click to open. |
cirosantilli
changed the title
cirosantilli
force-pushed
the
forbid-invalid-import
branch
2 times, most recently
from
d80b720
to
37c597c
Compare
| group = Group.new(:name => group_name) | ||
| group.path = group_name | ||
| group.owner = user | ||
| if group.save |
There was a problem hiding this comment.
Do we want validations to run here? i.e. save!?
There was a problem hiding this comment.
IIUC .save already does validations and returns false on fail: the difference is that save! would raise: http://guides.rubyonrails.org/active_record_validations.html#when-does-validation-happen-questionmark
|
@cirosantilli Can you please make this mergeable again? |
of type `repos_path/group/repo.git`. Before this, any other location like `repos_path/repo.git` or `repos_path/group/XXX/repo.git` does generate new projects, but these projects are empty since no copy is done.
cirosantilli
force-pushed
the
forbid-invalid-import
branch
from
37c597c
to
9c96ba3
Compare
cirosantilli
changed the title
cirosantilli
changed the title
|
@jvanbaarsen updated. Cannot reproduce error locally. |
|
Hm the weird thing is, one built is successful, and the other is not.. Can you rebase? Maybe it works after that :) |
|
This merge request has been closed because a request for more information has not been reacted to for more than 2 weeks. If you respond and conform to the merge request guidelines in our contributing guidelines we will reopen this merge request. |
cirosantilli
changed the title
|
Is this just being ignored now? I just spent half an hour going through the MANY wiki articles and google results trying to figure out why the repositories that I imported [per the docs|https://github.com/gitlabhq/gitlabhq/blob/master/lib/tasks/gitlab/import.rake] were empty, before I found this PR. |
|
@jantman GitLab ignores PRs if we don't update them in 2 weeks after request. They took too long to review and I had lost interest when they requested update. Feel free to pull this, make it mergeable and a new PR. If you make this mergeable, there is some chance that it will get merged. I think it's not a very good GitLab policy... if something is worth being reviewed and merged by gitlab, it is also worth being rebased by gitlab. :-) |
of type
repos_path/group/repo.git.Before this, any other location like
repos_path/repo.gitor
repos_path/group/XXX/repo.gitdoes generate new projects, butthese projects are empty since no copy is done.
Fix https://github.com/gitlabhq/gitlabhq/issues/4137
This behavior probably exists to support the old global repositories, but since it is broken already, I propose we remove support for that once and for all here. Let users put their repositories on the regular repository structure only which is less confusing and easier to maintain.
Implementation notes:
group_name == '.'is not possible since glob does not expand to., so that logic was removed.