Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitalize URL in "Home page URL" #9436

Merged
merged 1 commit into from
Aug 18, 2015
Merged

Conversation

bbodenmiller
Copy link
Contributor

URL is an acronym and as such should be capitalized

I'm failing to find where else this is defined... can someone point me to the right location?

@stanhu
Copy link
Member

stanhu commented Jul 7, 2015

You have to modify this line.

Change the line to:

      = f.label :home_page_url, 'Home page URL', class: 'control-label col-sm-2'

@bbodenmiller bbodenmiller changed the title WIP: capitalize URL in "Home page URL" capitalize URL in "Home page URL" Jul 26, 2015
@bbodenmiller
Copy link
Contributor Author

Should be ready to review now.

@stanhu
Copy link
Member

stanhu commented Jul 28, 2015

Please rebase master, and the tests should pass.

@bbodenmiller
Copy link
Contributor Author

@stanhu Rebase complete.

@bbodenmiller
Copy link
Contributor Author

@stanhu redid the commit to try and fix the CI issue... looks to be unrelated.

stanhu added a commit that referenced this pull request Aug 18, 2015
capitalize URL in "Home page URL"
@stanhu stanhu merged commit adebf70 into gitlabhq:master Aug 18, 2015
@bbodenmiller bbodenmiller deleted the patch-4 branch August 18, 2015 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants