Use LDAP/AD stored avatar thumbnail in preference to Gravatar #9858
Conversation
thechile
force-pushed
the
ldap_user_avatar_lookup
branch
3 times, most recently
from
98fda1c
to
7dd20c6
Compare
|
Can someone tell me how i should update the Gemfile and Gemfile.lock for Gitlab ? I've added a new Gem to Gemfile and locally it works OK but Semaphore CI is failing. Looking at the Gemfile.lock there are differences in gems such as net-ssh missing in mine. Not really sure why.. I just checked out Gemfile from master, added the new Gem and then ran 'bundle install'. Is this wrong ? |
Allow a user’s LDAP/AD stored avatar thumbnail to be queried and if found, used in preference to the Gravatar service. Note for Enterprise Edition: For EE, it'll work fine but only on the first defined LDAP provider. As noted in the code, I’m not sure the best way to resolve the users LDAP provider from within gravatar_service.rb but if someone can point me in the right direction then it'll be easy to support multiple LDAP providers. The alternative was to loop through all defined providers for a match but this seemed wasteful if the possibility existed to just resolve the users provider directly.
thechile
force-pushed
the
ldap_user_avatar_lookup
branch
from
7dd20c6
to
0169593
Compare
|
Thanks for the contribution to GitLab! Unfortunately we're no longer accepting Pull Requests through the GitHub project. If you'd like to get this merged, I encourage you to open this as a Merge Request on the GitLab.com project. Feel free to ping me (@connorshea) and I'll get the right person assigned to it. Apologies for the troubles, and thanks again for helping improve the project! ❤️ |
Allow a user’s LDAP/AD stored avatar thumbnail to be queried and if found, used in preference to the Gravatar service.
Note for Enterprise Edition:
For EE, it'll work fine but only on the first defined LDAP provider. As noted in the code, I’m not sure the best way to resolve the users LDAP provider from within gravatar_service.rb but if someone can point me in the right direction then it'll be easy to support multiple LDAP providers. The alternative was to loop through all defined providers for a match but this seemed wasteful if the possibility existed to just resolve the users provider directly.
This feature was also referenced in: