Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/gitlab_service_jira: several cleanup of tech debt #1069

Merged
merged 1 commit into from
May 21, 2022
Merged

resource/gitlab_service_jira: several cleanup of tech debt #1069

merged 1 commit into from
May 21, 2022

Conversation

timofurrer
Copy link
Member

This change set cleans up a few things in the gitlab_service_jira resource:

  • properly use resource ID in read function
  • use passthrough importer
  • state in docs that jira_issue_transition_id attribute cannot be imported
  • add import verification test steps to _basic test and remove dedicated _import test

@timofurrer timofurrer added this to the v3.15.0 milestone May 2, 2022
@timofurrer timofurrer requested a review from armsnyder May 2, 2022 17:57
@timofurrer timofurrer self-assigned this May 2, 2022
PatrickRice-KSC
PatrickRice-KSC previously approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@PatrickRice-KSC PatrickRice-KSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM! 🎉

internal/provider/resource_gitlab_service_jira.go Show resolved Hide resolved
@github-actions github-actions bot added the merge-conflict PR cannot be merged due to a merge conflict label May 13, 2022
@github-actions
Copy link

This pull request has merge conflicts. Please rebase your branch onto main.

armsnyder
armsnyder previously approved these changes May 14, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@timofurrer
resource/gitlab_service_jira: Cleanup ID usage in READ, use passthrou…
98ea574 
…gh importer and state import issues with `jira_issue_transition_id` attribute
@timofurrer timofurrer dismissed stale reviews from armsnyder and PatrickRice-KSC via 98ea574 May 15, 2022 15:44
@github-actions github-actions bot removed the merge-conflict PR cannot be merged due to a merge conflict label May 15, 2022
@github-actions
Copy link

Conflicts are resolved. Thank you! 😀

@timofurrer timofurrer merged commit ea3e3e2 into gitlabhq:main May 21, 2022
@github-actions
Copy link

This functionality has been released in v3.15.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armsnyder armsnyder armsnyder approved these changes

@PatrickRice-KSC PatrickRice-KSC PatrickRice-KSC approved these changes

Assignees

@timofurrer timofurrer

Labels
documentation provider resource Adds or modifies a resource size/M technical debt tests
Milestone
v3.15.0
3 participants
@timofurrer @armsnyder @PatrickRice-KSC