Fix acc tests #118
Merged
Fix acc tests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
roidelapluie
force-pushed
the
acctest
branch
3 times, most recently
from
a2713ff
to
f4bee7b
Compare
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
|
@jorcau do you approve this? |
This was referenced May 1, 2019
jorcau
approved these changes
May 2, 2019
There was a problem hiding this comment.
LGTM! However I would have kept the .travis.yml CI file as it was before. I feel like it was more compact and less redondant. Did you make the change to be able to do the if [[ $MAKE_TARGET != "testacc" ]] check? If so, I'd suggest to add a new rule like testacc_ci in the makefile with bash scripts/start-gitlab.sh in its recipe before testacc. But that's just a suggestion :).
|
I do not care about the complexity of the travis.yml. what I care is easy to browse travis reports that will help us cut the time to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu