Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitLab external URL configuration #1206

Closed

Conversation

timofurrer
Copy link
Member

This will fix the acceptance testing instance to have a proper external
URL configured. With that redirects within GitLab will work (e.g. from
the WebIDE back to the repository) and stuff like clone URLs etc.

This will fix the acceptance testing instance to have a proper external
URL configured. With that redirects within GitLab will work (e.g. from
the WebIDE back to the repository) and stuff like clone URLs etc.
@timofurrer timofurrer added the DX Developer Experience, e.g. contributing, readme, makefile, issue / pr template changes label Aug 8, 2022
@timofurrer timofurrer self-assigned this Aug 8, 2022
@timofurrer
Copy link
Member Author

This change seems to have the drawback that GitLab cannot reach a repository it hosts with the external URL. We are currently having this project in the TestAccGitlabProject_importURL which tries to import a repository hosted on the same GitLab instance.

Error: POST http://127.0.0.1:8080/api/v4/projects: 422 {message: http://127.0.0.1:8080/root/base-137441643613142598.git is not a valid HTTP Git repository}

One possible solution might be to change the nginx port to the same as the port used for the container port forwarding. Let's see ...

@timofurrer
Copy link
Member Author

I'm currently having some issues with getting this ready - since this is not urgent - I'm going to close for now and will re-open at a later time ;)

@timofurrer timofurrer closed this Aug 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DX Developer Experience, e.g. contributing, readme, makefile, issue / pr template changes size/XS tools
1 participant