Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Enabling pre-existing deploy key on a project #176

Merged
merged 10 commits into from
Oct 17, 2019

Conversation

primeroz
Copy link
Contributor

@primeroz primeroz commented Sep 17, 2019

fixes #64

Allow to enable already existing deploy key on a project by ID

variable keys_to_enable {
  type = list(string)
  default = [ "678", "901" ]
}

variable project {
  type = string
  default = "12345"
}

resource "gitlab_deploy_key_enable" "keys" {
  count   = length(var.keys_to_enable)
  project = var.project
  key_id  = element(var.keys_to_enable, count.index)
}

@primeroz
Copy link
Contributor Author

I did not realize the CI would run on a local dockerized gitlab ( which make sense ) so the key i used in the test is not availble.

will change to pre-create a key just for the test sake

Copy link
Collaborator

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments

gitlab/resource_gitlab_deploy_key_enable.go Outdated Show resolved Hide resolved
gitlab/resource_gitlab_deploy_key_enable.go Outdated Show resolved Hide resolved
website/docs/r/deploy_key_enable.html.markdown Outdated Show resolved Hide resolved
@primeroz
Copy link
Contributor Author

@roidelapluie pushed some changes and added a comment.

I would have expected Ci to trigger again but can't see it happening

@primeroz
Copy link
Contributor Author

primeroz commented Oct 1, 2019

@roidelapluie do you have any update on this ? thanks a lot

If a resource have manually been removed from the UI then error out and let the operator figure what is going on
@primeroz
Copy link
Contributor Author

primeroz commented Oct 1, 2019

@roidelapluie all changes done.

thanks !

@primeroz
Copy link
Contributor Author

primeroz commented Oct 7, 2019

@roidelapluie let me know if there is anything more you want me to change on this, i just don't want to miss the next release if is good since i heavily rely on this feature and i am currently running a local build of the provider which is not ideal.

thanks!

@roidelapluie roidelapluie merged commit 714a454 into gitlabhq:master Oct 17, 2019
@roidelapluie
Copy link
Collaborator

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants