Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data sources gitlab_project_protected_branch(es) #551

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Add data sources gitlab_project_protected_branch(es) #551

merged 4 commits into from
Jan 21, 2022

Conversation

sirlatrom
Copy link
Contributor

@sirlatrom sirlatrom commented Feb 4, 2021

Fixes #549.

Signed-off-by: Sune Keller <absukl@almbrand.dk>
Signed-off-by: Sune Keller <absukl@almbrand.dk>
…(es)

Signed-off-by: Sune Keller <absukl@almbrand.dk>
@sirlatrom sirlatrom marked this pull request as ready for review February 4, 2021 14:23
@armsnyder
Copy link
Collaborator

Can you fix these test failures please?

=== RUN   TestAccDataGitlabProjectProtectedBranchSearch
Error:     testing.go:684: Step 0 error: errors during plan:
        
        Error: "branch": required field is not set
        
          on /tmp/tf-test957964864/main.tf line 8:
          (source code not available)
        
        
--- FAIL: TestAccDataGitlabProjectProtectedBranchSearch (0.22s)
=== RUN   TestAccDataGitlabProjectProtectedBranchesSearch
Error:     testing.go:684: Step 0 error: errors during plan:
        
        Error: "branch": required field is not set
        
          on /tmp/tf-test150129522/main.tf line 8:
          (source code not available)
        
        
--- FAIL: TestAccDataGitlabProjectProtectedBranchesSearch (0.20s)

By the way there are new instructions in the README for running acceptance tests you could try out.

This is normally the case when creating from a template project, but not in an empty one.

Signed-off-by: Sune Keller <absukl@almbrand.dk>
@sirlatrom
Copy link
Contributor Author

@armsnyder Acceptance tests fixed, thanks for pointing them out.

@nagyv nagyv merged commit febe745 into gitlabhq:master Jan 21, 2022
@sirlatrom sirlatrom deleted the fix-549 branch January 21, 2022 17:06
timofurrer added a commit to timofurrer/terraform-provider-gitlab that referenced this pull request Jan 22, 2022
@timofurrer
Copy link
Member

@nagyv This merge caused master to fail, see the fixes here: #785

timofurrer added a commit to timofurrer/terraform-provider-gitlab that referenced this pull request Jan 22, 2022
timofurrer added a commit to timofurrer/terraform-provider-gitlab that referenced this pull request Jan 22, 2022
timofurrer added a commit to timofurrer/terraform-provider-gitlab that referenced this pull request Jan 22, 2022
nagyv added a commit that referenced this pull request Jan 22, 2022
@armsnyder armsnyder added this to the 3.9.0 milestone Jan 26, 2022
eliobischof pushed a commit to eliobischof/terraform-provider-gitlab that referenced this pull request Feb 1, 2022
eliobischof pushed a commit to eliobischof/terraform-provider-gitlab that referenced this pull request Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This functionality has been released in 3.9.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants