Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gitlab group badges #673

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

zbindenren
Copy link
Contributor

This adds support for group badges.

@zbindenren zbindenren force-pushed the group_badges branch 2 times, most recently from 6ad2f8a to a08b218 Compare July 24, 2021 08:34
var badge gitlab.GroupBadge
rInt := acctest.RandInt()

resource.Test(t, resource.TestCase{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if there was a TestStep or CheckDestroy here that tests what happens if the badge is destroyed.

Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm. The test comment is non-blocking.

@nagyv nagyv merged commit 39b0b6d into gitlabhq:master Jan 21, 2022
@zbindenren
Copy link
Contributor Author

Thx

@armsnyder armsnyder added this to the 3.9.0 milestone Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This functionality has been released in 3.9.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants