Add require_password_to_approve option for MRs #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
added
enhancement
upstream api alignment
timofurrer
previously approved these changes
Jan 27, 2022
armsnyder
requested changes
Jan 28, 2022
github-actions
bot
added
the
merge-conflict
|
This pull request has merge conflicts. Please rebase your branch onto |
|
@grv87 are you still willing to work on this? IHMO it's almost ready for a merge :) If not, we can follow up on it :) |
timofurrer
force-pushed
the
feature/require_password_to_approve
branch
from
c68ae39
to
4e8d1b5
Compare
|
Conflicts are resolved. Thank you! 😀 |
github-actions
bot
added
documentation
provider
resource
|
I took the liberty and added the necessary changes to get this merged. |
timofurrer
added
safe to test
and removed
needs-rebase
timofurrer
approved these changes
Feb 24, 2022
armsnyder
approved these changes
Feb 25, 2022
|
This functionality has been released in v3.11.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
require_password_to_approveargument togitlab_project_level_mr_approvalsresource.Follow-up for xanzy/go-gitlab#1116
PR Checklist
//lintignorecomments that came from copied code. Linter rules are meant to be enforced on new code.