Implement archive_on_destroy attribute for projects. Closes #761
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armsnyder
reviewed
Jan 28, 2022
armsnyder
approved these changes
Jan 28, 2022
timofurrer
force-pushed
the
feature/archive-on-destroy-761
branch
from
0533e57
to
aaf0e0a
Compare
armsnyder
reviewed
Jan 29, 2022
This change implements an `archive_on_destroy` attribute on the `gitlab_project` resource. It defaults to `false`, if set to `true`, on a destroy it will *archive* the project instead of deleting it. This is especially useful in organizations where repositories need to be kept for regulatory purposes and can't be deleted.
timofurrer
force-pushed
the
feature/archive-on-destroy-761
branch
from
aaf0e0a
to
8f6754b
Compare
|
lgtm 😄 |
|
This functionality has been released in 3.9.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements an
archive_on_destroyattribute on thegitlab_projectresource. It defaults tofalse, if set totrue, ona destroy it will archive the project instead of deleting it.
This is especially useful in organizations where repositories need to
be kept for regulatory purposes and can't be deleted.
PS: the diff is a mess: I've basically just
if'edtheDeleteProjectcase depending on thearchive_on_destroyattribute and calledArchiveProjectin the new branch :)