Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource gitlab_system_hook #929

Merged
merged 1 commit into from Mar 29, 2022
Merged

New Resource gitlab_system_hook #929

merged 1 commit into from Mar 29, 2022

Conversation

timofurrer
Copy link
Member

@timofurrer timofurrer commented Mar 7, 2022 •
edited

Closes #180

@timofurrer timofurrer self-assigned this Mar 7, 2022
timofurrer
timofurrer commented Mar 7, 2022
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@timofurrer timofurrer added the blocked We are currently blocked to implement this label Mar 7, 2022
armsnyder
armsnyder previously requested changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! one suggestion.

internal/provider/resource_gitlab_system_hook.go Outdated Show resolved Hide resolved
@timofurrer timofurrer added this to the v3.13.0 milestone Mar 22, 2022
@timofurrer timofurrer removed the blocked We are currently blocked to implement this label Mar 22, 2022
nagyv
nagyv approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@nagyv nagyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved following the approval from @PatrickRice-KSC

@timofurrer timofurrer merged commit 331e8dc into gitlabhq:main Mar 29, 2022
@github-actions
Copy link

This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nagyv nagyv nagyv approved these changes

@PatrickRice-KSC PatrickRice-KSC PatrickRice-KSC approved these changes

@armsnyder armsnyder Awaiting requested review from armsnyder

Assignees

@timofurrer timofurrer

Labels
documentation provider resource Adds or modifies a resource size/L tests
Milestone
v3.13.0
4 participants
@timofurrer @nagyv @armsnyder @PatrickRice-KSC