resource/gitlab_project_approval_rule: fix potential accidental destroy of resource if not in first page #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
added
blocked
timofurrer
removed
blocked
…roy of resource if not in first page This fixes a potential bug that the resource is marked for destroy after a read, because it was not found on the first page. Pagination was not implemented. However, there exist a specific API to get a single project-level approval rule. I have implemented it in go-gitlab: * xanzy/go-gitlab#1410 After it is released, we should be able to just rebase and LGTM ;)
timofurrer
force-pushed
the
feature/approval-rule-get
branch
from
36e9b75
to
b991b9d
Compare
github-actions
bot
added
data-source
armsnyder
approved these changes
Mar 19, 2022
|
This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential bug that the resource is marked for destroy after a read,
because it was not found on the first page. Pagination was not implemented.
However, there exist a specific API to get a single project-level approval rule.
I have implemented it in go-gitlab:
After it is released, we should be able to just rebase and LGTM ;)
Refs: #949