Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all missing importers #960

Merged
merged 4 commits into from Mar 15, 2022

Conversation

timofurrer
Copy link
Member

This change set together with (#954) implements all missing importers and therefore closes the long open #36 .

I've focused on the importer themselves and not so much about the underlying ids.
I'll follow up with an issue describing the current state of resource ids currently in use. I hope that we can streamline those for v4 of the provider ...

@timofurrer timofurrer added this to the v3.13.0 milestone Mar 14, 2022
@timofurrer timofurrer self-assigned this Mar 14, 2022
@timofurrer timofurrer linked an issue Mar 14, 2022 that may be closed by this pull request
examples/resources/gitlab_deploy_token/import.sh Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_deploy_token.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_deploy_token.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_deploy_token.go Outdated Show resolved Hide resolved
@timofurrer
Copy link
Member Author

@jtymes good catches, thanks for the review!

@timofurrer timofurrer merged commit 375586b into gitlabhq:main Mar 15, 2022
@github-actions
Copy link

This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants