resource/gitlab_repository_file: Support auto base64 encoding for content #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
provider
resource
timofurrer
changed the title
github-actions
bot
added
the
merge-conflict
|
This pull request has merge conflicts. Please rebase your branch onto |
timofurrer
force-pushed
the
feature/repository-file-encoding
branch
from
2213453
to
5c2e9b7
Compare
github-actions
bot
removed
the
merge-conflict
|
Conflicts are resolved. Thank you! 😀 |
github-actions
bot
added
the
merge-conflict
|
This pull request has merge conflicts. Please rebase your branch onto |
timofurrer
force-pushed
the
feature/repository-file-encoding
branch
from
5c2e9b7
to
dc7ba1a
Compare
github-actions
bot
removed
the
merge-conflict
|
Conflicts are resolved. Thank you! 😀 |
PatrickRice-KSC
previously approved these changes
Mar 25, 2022
timofurrer
force-pushed
the
feature/repository-file-encoding
branch
from
dc7ba1a
to
5d665e5
Compare
nagyv
approved these changes
Mar 28, 2022
|
This functionality has been released in v3.13.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets allows to specify not-yet base64 encoded
contentand the resource will automatically base64 encode it for the API.This will make the plan match more readable and will solve the limitations described in #956
Initially I thought it's best to use a
DiffSuppressFuncand always store thecontentas base64. However, I think it's best to store it in the same format (text vs. plan) as given in the config. This ensures that access the resource content in the config produces deterministic results.Closes: #956