Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support creating project in user namespace using namespace_id from user resources / data sources #987

Merged
merged 4 commits into from
Apr 23, 2022

Conversation

timofurrer
Copy link
Member

@timofurrer timofurrer commented Mar 26, 2022

This change set addresses #85. It implements the namespace_id attribute on the gitlab_user and gitlab_users resource and data sources respectively.

It also adds a test and example for the gitlab_project resource for creating a project in a users namespace given the namespace_id from the former mentioned resources / data sources.

I've implemented this upstream in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82045 and will be available in GitLab 14.10, thus this PR is blocked until:

Closes: #85

@timofurrer timofurrer self-assigned this Mar 26, 2022
@timofurrer timofurrer added the blocked We are currently blocked to implement this label Mar 26, 2022
@github-actions github-actions bot added data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource tests size/M labels Mar 26, 2022
@timofurrer timofurrer added this to the v3.X (first release for GitLab 14.10) milestone Mar 26, 2022
@timofurrer timofurrer linked an issue Mar 26, 2022 that may be closed by this pull request
@timofurrer timofurrer force-pushed the feature/user-namespace-id branch 2 times, most recently from 89177fa to 3f8113f Compare March 26, 2022 09:09
internal/provider/data_source_gitlab_user.go Outdated Show resolved Hide resolved
internal/provider/data_source_gitlab_users.go Outdated Show resolved Hide resolved
internal/provider/resource_gitlab_user.go Outdated Show resolved Hide resolved
@timofurrer timofurrer marked this pull request as ready for review March 26, 2022 17:16
@timofurrer timofurrer modified the milestones: v3.X (first release for GitLab 14.10), v3.14.0 Apr 22, 2022
@timofurrer timofurrer force-pushed the feature/user-namespace-id branch 2 times, most recently from 112de43 to 488ff81 Compare April 22, 2022 14:30
@timofurrer timofurrer removed the blocked We are currently blocked to implement this label Apr 23, 2022
@timofurrer timofurrer merged commit be313f1 into gitlabhq:main Apr 23, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

This functionality has been released in v3.14.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data-source Adds or modifies a data-source documentation provider resource Adds or modifies a resource size/M tests
3 participants