tests: scalingo validation consistent test #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't know it when I made gitleaks#1358
|
|
3 tasks
baruchiro
added a commit
to Checkmarx/gitleaks
that referenced
this pull request
Mar 28, 2024
### Description: Sometimes the tp of Scalingo is failing during the Github Actions workflow and after re-triggering it passed. I think the problem was when the generated example secret was ended with `-`, and combined with the `Regex` that expect for a word boundary `\b`, it was failed. I think in any way it is better to use the common `generateUniqueTokenRegex` instead of wrapping the regex with `\b`. ### Checklist: * [x] Does your PR pass tests? * [x] Have you written new tests for your changes? * [x] Have you lint your code locally prior to submission? Original: gitleaks#1359
baruchiro
force-pushed
the
inconsistency
branch
from
0557dac
to
ff3cd92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sometimes the tp of Scalingo is failing during the Github Actions workflow and after re-triggering it passed. I think the problem was when the generated example secret was ended with
-, and combined with theRegexthat expect for a word boundary\b, it was failed.I think in any way it is better to use the common
generateUniqueTokenRegexinstead of wrapping the regex with\b.Checklist: