Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: scalingo validation consistent test #7

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

baruchiro
Copy link

Description:

Sometimes the tp of Scalingo is failing during the Github Actions workflow and after re-triggering it passed. I think the problem was when the generated example secret was ended with -, and combined with the Regex that expect for a word boundary \b, it was failed.

I think in any way it is better to use the common generateUniqueTokenRegex instead of wrapping the regex with \b.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

Original: gitleaks#1359

@baruchiro baruchiro marked this pull request as draft March 28, 2024 13:57
@baruchiro baruchiro marked this pull request as ready for review March 28, 2024 13:57
@baruchiro baruchiro merged commit ca72e87 into master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant