This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add GWG and OGO logo assets #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GWG logo assets added 9211839 |
Signed-off-by: iboonox <iheb.dev@gmail.com>
Signed-off-by: iboonox <iheb.dev@gmail.com>
Signed-off-by: iboonox <iheb.dev@gmail.com>
scottrigby
reviewed
Apr 9, 2021
There was a problem hiding this comment.
@iboonox these look fantastic IMO 🏆
One note, the assets/logos/OGO/styleguide.svg file looks like a different typeface than Lato is used in the SVG image itself. GitHub won't allow me to make a suggested change on a binary file – do you see what I mean?
|
No the font used is Lato |
scottrigby
approved these changes
Apr 12, 2021
This was referenced Apr 12, 2021
Merged
iboonox
added a commit
to iboonox/gitops-working-group
that referenced
this pull request
Apr 18, 2021
* Add OGO logo assets Signed-off-by: iboonox <iheb.dev@gmail.com> * Add GWG logo assets + change assets folder structure Signed-off-by: iboonox <iheb.dev@gmail.com> * Fix source folder path Signed-off-by: iboonox <iheb.dev@gmail.com>
|
@scottrigby: does this change with the naming change as well? |
|
@amye I believe we should be set with these designs:
If I understood what you meant correctly |
|
That is what I was asking yes! As for the 2nd, having all the artwork in one place is fine, put in a PR under 'other' in /artwork |
This was referenced Apr 26, 2021
Closed
|
@amye OK perfect 👌 PRs made: I'll also post in the TOC project onboarding issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.