Import of BOOK/Git-Repository-1.307 from CPAN.

gitpan-cpan-distribution: Git-Repository gitpan-cpan-version: 1.307 gitpan-cpan-path: BOOK/Git-Repository-1.307.tar.gz gitpan-cpan-author: BOOK gitpan-cpan-maturity: released
gitpan · Oct 23, 2014 · 0f2101b · 0f2101b
1 parent 521eb46
commit 0f2101b
Show file tree

Hide file tree

Showing 13 changed files with 36 additions and 29 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,13 @@
 Revision history for Git-Repository
 
+1.307 Fri Jul 26 2013
+        [ENHANCEMENTS]
+        - avoid creating zombie processes in _is_git
+        - require the latest System-Command, as it properly works with
+          FCGI, Plack et al.
+        [DOCUMENTATION]
+        - various minor documentation improvements
+
 1.306 Tue Jul 2 2013
         [DOCUMENTATION]
         - document how to run git from cwd in Git::Repository::Tutorial

diff --git a/META.yml b/META.yml
@@ -26,12 +26,12 @@ requires:
   File::Temp: 0
   IO::Handle: 0
   Scalar::Util: 0
-  System::Command: 1.100
+  System::Command: 1.102
   Test::Builder: 0
   perl: 5.006
   strict: 0
   warnings: 0
 resources:
   bugtracker: http://rt.cpan.org/NoAuth/Bugs.html?Dist=Git-Repository
   repository: http://github.com/book/Git-Repository.git
-version: 1.306
+version: 1.307
diff --git a/Makefile.PL b/Makefile.PL
@@ -34,12 +34,12 @@ my %WriteMakefileArgs = (
     "File::Temp" => 0,
     "IO::Handle" => 0,
     "Scalar::Util" => 0,
-    "System::Command" => "1.100",
+    "System::Command" => "1.102",
     "Test::Builder" => 0,
     "strict" => 0,
     "warnings" => 0
   },
-  "VERSION" => "1.306",
+  "VERSION" => "1.307",
   "test" => {
     "TESTS" => "t/*.t"
   }

diff --git a/dist.ini b/dist.ini
@@ -19,7 +19,7 @@ match    = cover_db
 [AutoPrereqs]
 
 [Prereqs]
-System::Command = 1.100
+System::Command = 1.102
 
 [ReportVersions::Tiny]
 

diff --git a/lib/Git/Repository.pm b/lib/Git/Repository.pm
@@ -1,6 +1,6 @@
 package Git::Repository;
 {
-  $Git::Repository::VERSION = '1.306';
+  $Git::Repository::VERSION = '1.307';
 }
 
 use warnings;
@@ -299,7 +299,7 @@ Git::Repository - Perl interface to Git repositories
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 

diff --git a/lib/Git/Repository/Command.pm b/lib/Git/Repository/Command.pm
@@ -1,6 +1,6 @@
 package Git::Repository::Command;
 {
-  $Git::Repository::Command::VERSION = '1.306';
+  $Git::Repository::Command::VERSION = '1.307';
 }
 
 use strict;
@@ -80,9 +80,9 @@ sub _is_git {
         if !( defined $git && -x $git );
 
     # try to run it
-    my ( $pid, $in, $out, $err )
-        = System::Command->spawn( $git, @args, '--version' );
-    my $version = do { local $/ = "\n"; <$out>; };
+    my $cmd = System::Command->new( $git, @args, '--version' );
+    my $version = do { local $/ = "\n"; $cmd->stdout->getline; };
+    $cmd->close;
 
     # does it really look like git?
     return $binary{$type}{$key}{$binary}{$args}
@@ -205,7 +205,7 @@ Git::Repository::Command - Command objects for running git
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 
@@ -397,8 +397,6 @@ following code:
 
 C<$fh> is opened and points to the output of the git subcommand, while
 the anonymous L<Git::Repository::Command> object has been destroyed.
-Once C<$fh> is destroyed, the subprocess will be reaped, thus avoiding
-zombies.
 
 After the call to C<close()>, the following attributes will be defined:
 

diff --git a/lib/Git/Repository/Log.pm b/lib/Git/Repository/Log.pm
@@ -1,6 +1,6 @@
 package Git::Repository::Log;
 {
-  $Git::Repository::Log::VERSION = '1.306';
+  $Git::Repository::Log::VERSION = '1.307';
 }
 
 use strict;
@@ -80,7 +80,7 @@ Git::Repository::Log - Class representing git log data
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 

diff --git a/lib/Git/Repository/Log/Iterator.pm b/lib/Git/Repository/Log/Iterator.pm
@@ -1,6 +1,6 @@
 package Git::Repository::Log::Iterator;
 {
-  $Git::Repository::Log::Iterator::VERSION = '1.306';
+  $Git::Repository::Log::Iterator::VERSION = '1.307';
 }
 
 use strict;
@@ -84,7 +84,7 @@ Git::Repository::Log::Iterator - Split a git log stream into records
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 

diff --git a/lib/Git/Repository/Plugin.pm b/lib/Git/Repository/Plugin.pm
@@ -1,6 +1,6 @@
 package Git::Repository::Plugin;
 {
-  $Git::Repository::Plugin::VERSION = '1.306';
+  $Git::Repository::Plugin::VERSION = '1.307';
 }
 
 use strict;
@@ -41,7 +41,7 @@ Git::Repository::Plugin - Base class for Git::Repository plugins
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 

diff --git a/lib/Git/Repository/Plugin/Log.pm b/lib/Git/Repository/Plugin/Log.pm
@@ -1,6 +1,6 @@
 package Git::Repository::Plugin::Log;
 {
-  $Git::Repository::Plugin::Log::VERSION = '1.306';
+  $Git::Repository::Plugin::Log::VERSION = '1.307';
 }
 
 use warnings;
@@ -46,7 +46,7 @@ Git::Repository::Plugin::Log - Add a log() method to Git::Repository
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 

diff --git a/lib/Git/Repository/Tutorial.pod b/lib/Git/Repository/Tutorial.pod
@@ -11,7 +11,7 @@ Git::Repository::Tutorial - Control git from Perl using Git::Repository
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 
@@ -201,7 +201,7 @@ The stealthiest way (restricted to a single command):
 
     $r->run( ..., { env => { LC_ALL => 'C' } } );
 
-=head2 Ensure the Git commands are run from the current workding directory
+=head2 Ensure the Git commands are run from the current working directory
 
 By default, L<Git::Repository::Command> will C<chdir()> to the root of
 the work tree before launching the requested Git command.
@@ -259,7 +259,8 @@ it for all commands run for it:
 
 Using negative codes will make these values non-fatal:
 
-    # all exit codes are fatal, except 3 and 7
+    # the above call to new() makes all exit codes fatal
+    # but 3 and 7 won't be fatal for this specific run
     $r->run( ..., { fatal => [ -3, -7 ] } );
 
 When the list contains a single item, there is no need to use an array
@@ -268,7 +269,7 @@ reference:
     # same as [ "!0" ]
     $r = Git::Repository->new( { fatal => "!0" } );
 
-    # only 17 is fatal
+    # remove 17 from the list of fatal exit codes for this run only
     $r->run( ..., { fatal => -17 } );
 
 See L<Git::Repository::Command> for other available options.

diff --git a/lib/Test/Git.pm b/lib/Test/Git.pm
@@ -1,6 +1,6 @@
 package Test::Git;
 {
-  $Test::Git::VERSION = '1.306';
+  $Test::Git::VERSION = '1.307';
 }
 
 use strict;
@@ -75,7 +75,7 @@ Test::Git - Helper functions for test scripts using Git
 
 =head1 VERSION
 
-version 1.306
+version 1.307
 
 =head1 SYNOPSIS
 

diff --git a/t/000-report-versions-tiny.t b/t/000-report-versions-tiny.t
@@ -59,7 +59,7 @@ eval { $v .= pmver('File::Spec','any version') };
 eval { $v .= pmver('File::Temp','any version') };
 eval { $v .= pmver('IO::Handle','any version') };
 eval { $v .= pmver('Scalar::Util','any version') };
-eval { $v .= pmver('System::Command','1.100') };
+eval { $v .= pmver('System::Command','1.102') };
 eval { $v .= pmver('Test::Builder','any version') };
 eval { $v .= pmver('Test::More','0.88') };
 eval { $v .= pmver('constant','any version') };