Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comments not visible from Pull Request view #5

Closed
marcdumais-work opened this issue May 10, 2018 · 2 comments
Closed

Review comments not visible from Pull Request view #5

marcdumais-work opened this issue May 10, 2018 · 2 comments

Comments

@marcdumais-work
Copy link

For PR 1858, only the initial comment, describing the PR content, is visible in the Pull Request view. Further conversations, visible from GH are not present. Not sure if it makes a difference, but the one visible comment contains an animated image.

I was still able to successfully add a comment, using the "Review Changes" button, from the view.
@svenefftinge
Copy link
Member

@akosyakov could you look into it?

@svenefftinge
Copy link
Member

I think this has been solved in the meantime.

fullmetalrooster pushed a commit that referenced this issue Feb 16, 2021
# This is a combination of 8 commits.
86e7486 
# This is the 1st commit message:

dev

# This is the commit message #2:

dev

# This is the commit message #3:

dev

# This is the commit message #4:

dev

# This is the commit message #5:

dev

# This is the commit message #6:

dev

# This is the commit message #7:

dev

# This is the commit message #8:

dev
@roboquat roboquat mentioned this issue Nov 15, 2021
Merged
@ttauchen ttauchen mentioned this issue Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenefftinge @marcdumais-work