Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: configure and validate the external database #6716

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Nov 15, 2021

Description

Enables use of external MySQL DB. This is necessary for AWS/Azure and other cloud providers

Related Issue(s)

Fixes gitpod-io/gitpod-microsoft-aks-guide#5

How to test

Release Notes

Configure and validate the external database

Documentation

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Nov 16, 2021

/werft run

👍 started the job as gitpod-build-sje-external-db.1

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6716 (1e36df4) into main (f3ecc7f) will decrease coverage by 1.72%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #6716      +/-   ##
========================================
- Coverage   7.89%   6.16%   -1.73%     
========================================
  Files         14      12       -2     
  Lines       1254    1086     -168     
========================================
- Hits          99      67      -32     
+ Misses      1152    1018     -134     
+ Partials       3       1       -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ecc7f...1e36df4. Read the comment docs.

@csweichel
Copy link
Contributor

did not run this, but code lgtm

/lgtm

@roboquat roboquat added the lgtm label Nov 18, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: e2f8de62d7ba7ba2f094de456710789f25ecd4a1

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 158acc4 into main Nov 18, 2021
@roboquat roboquat deleted the sje/external-db branch November 18, 2021 10:55
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External database
3 participants