ws-daemon: Apply the xfs limit in stages #10395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
reviewed
Jun 1, 2022
jenting
approved these changes
Jun 1, 2022
kylos101
reviewed
Jun 1, 2022
| _, err = xfs.exec(xfs.Dir, fmt.Sprintf("limit -p bsoft=%d bhard=%d %d", quota, quota, prjID)) | ||
|
|
||
| if isHard { | ||
| _, err = xfs.exec(xfs.Dir, fmt.Sprintf("limit -p bhard=%d %d", quota, prjID)) |
There was a problem hiding this comment.
@utam0k prior to making this change, were you able to add content to /workspace and exceed the quota?
Also, if the quota is exceeded in the regular workspace, what happens now to users if they try writing more content to /workspace, but at are the hard limit?
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the xfs limit in stages because ws-daemon uses some disk space at startup
Related Issue(s)
Fixes #10329
How to test
/wokspace(Recommend usedocker) e.g.dd if=/dev/zero of=zero.dat bs=1G count=1Release Notes
Documentation
No