Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric of PVC restore duration time #10623

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 13, 2022

Description

Add a metric of PVC restore duration time gitpod_ws_manager_volume_restore_seconds.

Related Issue(s)

Fixes #10195

How to test

  1. Create a workspace preview.
  2. Add GitHub integration.
  3. Enable feature flag persistent_volume_claim.
  4. Launch a workspace.
  5. Write some files.
  6. Stop a workspace.
  7. Port forward the ws-manager kubectl port-forward <ws-manager-pod> 9500:9500.
  8. Get the metric curl -XGET localhost:9500/metrics.
  9. Check the metric gitpod_ws_manager_volume_restore_seconds, it should match the time that PVC becomes Bound.

Release Notes

[experimental] add a metric to track volume restore time

Documentation

None

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting requested a review from a team June 13, 2022 12:03
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 13, 2022
@roboquat roboquat merged commit 3951854 into main Jun 13, 2022
@roboquat roboquat deleted the jenting/observability-add-metrics-10195 branch June 13, 2022 13:20
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observability: add metrics so we can measure frequency and duration of PVC snapshot backup and restore
4 participants