Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Make sure volume restore time is accurate #10640

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 14, 2022

Description

Address the volume restore time is incorrect if

  • launch a fresh new workspace (which means the PVC is not restoring from the VolumeSnapshot)
  • it falls into the backoff retry loop.

Related Issue(s)

Fixes the #10623 (comment)
Fixes #10195

How to test

Release Notes

None

Documentation

None

We might fall into the exponential backoff function, meaning that the
volume restore time would be calculated again even if we had already
calculated the volume restore time.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
… from the VolumeSnapshot

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting requested a review from a team June 14, 2022 04:11
@github-actions github-actions bot added team: workspace Issue belongs to the Workspace team and removed size/S labels Jun 14, 2022
@roboquat roboquat merged commit 39557c3 into main Jun 14, 2022
@roboquat roboquat deleted the jenting/observability-add-metrics-10195 branch June 14, 2022 05:30
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observability: add metrics so we can measure frequency and duration of PVC snapshot backup and restore
3 participants