-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] BlockedRepo UI #11446
[dashboard] BlockedRepo UI #11446
Conversation
started the job as gitpod-build-gpl-blocked-repo-ui.1 because the annotations in the pull request description changed |
d1de44e
to
f328629
Compare
@AlexTugarev Can you maybe 10mins tomorrow and help me fix the basics for the 🛹 ? 🙏 @gtsiolis I guess you're pretty busy, but: It would be awesome if you could have a look (independent of when we merge this) and come up with a nice version - happy to implement that. ✨ |
Looking at this now! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, @geropl! 🔮
Left some comments in case we'd like to address all these UX issues here or in a separate PR.
Approving to unblock merging this, but holding to let someone from the @gitpod-io/engineering-webapp
to take a closer look at the code changes. 🏓
/hold
f328629
to
0cf313f
Compare
/unhold I addressed as much of the suggestions as possible to still get the release train 🚆 😆 To reiterate why I think this is ok:
|
Thank you @andrew-farries and @gtsiolis for your valuable feedback! 🙏 |
Description
This still looks... ugly, but fixes the general issue of not being able to add blocked repositories from the UI.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: