Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout BlockedRepositories UI #11462

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Rollout BlockedRepositories UI #11462

merged 4 commits into from
Jul 20, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 19, 2022

Description

This PR does:

  • fix a bug with the delete functionality to work cross-cluster
  • polish the UI
    • explain search field (ref)
    • examples for regex patterns (ref)
    • warning that this can affect a lot of Gitpod users
    • fix "User Blocked" display (ref)

Related Issue(s)

Prior PR: #11446

Fixes: #11030

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl changed the title [server, db] Fix BlockedRepository.delete Polish BlockedRepositories UI Jul 19, 2022
@geropl
Copy link
Member Author

geropl commented Jul 19, 2022

@gtsiolis Do you have a reference for what you mentioned here? 🤔

@gtsiolis
Copy link
Contributor

@geropl For this iteration, we could reuse the text-based pattern we already have in project-level environment variables, see example settings. I'll open a follow-up issue with some more minor UX issues.

@geropl
Copy link
Member Author

geropl commented Jul 19, 2022

/werft run with-preview=true

👍 started the job as gitpod-build-gpl-11030-brs.5
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

@geropl I quickly summarized some UX issues in #11463, including the point you added here about warning users.

@geropl geropl changed the title Polish BlockedRepositories UI Finish BlockedRepositories UI Jul 19, 2022
@geropl geropl changed the title Finish BlockedRepositories UI Rollout BlockedRepositories UI Jul 19, 2022
@geropl
Copy link
Member Author

geropl commented Jul 19, 2022

Awesome @gtsiolis ! I tried to keep the checkboyes in #11463 up to date.

This is what we have now:
image

Not satisfied with the colors of the warning, but I'd rather have it there then not. 🧘 I tried to fix everything that does not require taste design experience. I feel next round has to be tackled by someone else. 😉

@geropl geropl marked this pull request as ready for review July 19, 2022 12:22
@geropl geropl requested a review from a team July 19, 2022 12:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 19, 2022
@geropl geropl requested a review from a team July 19, 2022 12:23
@roboquat roboquat added size/XL and removed size/M labels Jul 19, 2022
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team and removed size/XL labels Jul 19, 2022
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the installer side, but How about also removing the BlockedRepository type both from

  • install/installer/pkg/config/v1/experimental/experimental.go
  • install/pkg/components/server/types.go

as its not used anymore.

/hold for the same

@geropl
Copy link
Member Author

geropl commented Jul 20, 2022

Thank you @Pothulapati , done! 🙏

/unhold

@roboquat roboquat merged commit be09f01 into main Jul 20, 2022
@roboquat roboquat deleted the gpl/11030-brs branch July 20, 2022 12:05
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note-none size/XL team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move blocked repository configuration into the database and build admin UI to work with it
5 participants