Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Summary row to Gitpod overview dashboard #11506

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Add Summary row to Gitpod overview dashboard #11506

merged 1 commit into from
Jul 20, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 20, 2022

Description

By default the new row is collapsed

Gitpod-Overview-next-Grafana

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf requested review from a team July 20, 2022 14:30
@github-actions github-actions bot added team: IDE team: devx team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jul 20, 2022
geropl
geropl approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf Judging from the screenshot you shared workspace types are counted separately (maybe by cluster, or nodepool)?

LGTM besides ✔️

/hold

@aledbf
Copy link
Member Author

aledbf commented Jul 20, 2022

Judging from the screenshot you shared workspace types are counted separately (maybe by cluster, or nodepool)?

By cluster

ArthurSens
ArthurSens suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good!

It just needs a small change because we cannot make changes to the vendor folder. This folder is always created by automation with jsonnet-bundler and whatever changes we make here will be overridden when going to production.

Also, I've noticed that people are more comfortable with raw JSON. Do you wanna keep using jsonnet for this dashboard?

operations/observability/mixins/Makefile Outdated
Comment on lines 35 to 36
# Custom version of https://github.com/grafana/grafonnet-lib/pull/274
cp components/bar_gauge_panel.libsonnet vendor/github.com/grafana/grafonnet-lib/grafonnet/bar_gauge_panel.libsonnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works when developing locally, but won't work when importing those changes to our observability repository

We have another vendor file over there and it we can't move directories around when rendering dashboards with ArgoCD 😕

operations/observability/mixins/cross-teams/dashboards/gitpod-overview.libsonnet Outdated Show resolved Hide resolved
@aledbf
Copy link
Member Author

aledbf commented Jul 20, 2022

Do you wanna keep using jsonnet for this dashboard?

I just want to add a Summary. If someone wants to own such change across the dashboards, go 👍

@roboquat roboquat merged commit b9db8b3 into main Jul 20, 2022
@roboquat roboquat deleted the aledbf/summ branch July 20, 2022 16:32
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Jul 21, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

@geropl geropl geropl approved these changes

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/L team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aledbf @mustard-mh @ArthurSens @geropl @jenting @roboquat