[server] Reliably set log the value for volumeSnapshotId

[kylos101]

Description

Set the value for volumeSnapshotId one time.

Background: we're trying to log/capture the above field. Why? The problem is, sometimes a feature (PVC) is enabled for workspace start in production, and we do not know why. We added logging to learn more, but, it is missing this field volSnapshotId: volumeSnapshotId,.

Related Issue(s)

Related to #11823

How to test

Start a workspace

Release Notes

NONE

Documentation

Werft options:

• /werft with-preview

[kylos101]

/werft run

👍 started the job as gitpod-build-kylos101-fix-pvc-logging.1
(with .werft/ from main)

[werft-gitpod-dev-com]

started the job as gitpod-build-kylos101-fix-pvc-logging.3 because the annotations in the pull request description changed
(with .werft/ from main)

[kylos101]

Changing this to a constant, in hopes that we'll later be able to see the value here. Presently, we do not see the field at all in GCP logs. 🤔

[AlexTugarev]

This change has no effect at all. Just removes one of the rare comments.

As commented internally the value is undefined, thus the property gets erased during serialization of the log item's payload, which is basically this:

> JSON.stringify({foo: undefined})
'{}'

[kylos101]

Thanks, @AlexTugarev !

We know lastValidWorkspaceInstanceId has a value (because it was logged in a separate field).

So, now that we know fields with undefined values get removed from the logged object, we'll have to work to determine why workspace.context.snapshotBucketId is sometimes undefined.

[kylos101]

FYI, the preview environment will not work until #11966 is merged and this is rebased.

[kylos101]

/hold rebased, will test and remove hold once done

[kylos101]

Works:

[kylos101]

/unhold

[kylos101]

Dang, still not fixed.

Logs