Replace deprecated seccomp.security.alpha.kubernetes.io/pod annotation #11966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note-none
do-not-merge/work-in-progress
size/S
size/XL
and removed
size/S
labels
aledbf
force-pushed
the
aledbf/seccompa
branch
from
a4886ad
to
6886784
Compare
jenting
reviewed
Aug 10, 2022
| SecurityContext: &corev1.PodSecurityContext{}, | ||
| SecurityContext: &corev1.PodSecurityContext{ | ||
| // We're using a custom seccomp profile for user namespaces to allow clone, mount and chroot. | ||
| // Those syscalls don't make much sense in a non-userns setting, where we default to runtime/default using the PodSecurityPolicy. |
There was a problem hiding this comment.
The PSP is going to deprecated, correct? Then, I am not use why we keep the PSP wording within the comment.
There was a problem hiding this comment.
We don't have a replacement for PSP yet. I would prefer to keep that.
sagor999
approved these changes
Aug 10, 2022
jenting
approved these changes
Aug 10, 2022
This was referenced Aug 11, 2022
1 task
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The annotation will be removed in k8s 1.25
How to test
Werft options: